Enable linter for azure-rest-api-specs#29434
Merged
JimSuplizio merged 2 commits intoAzure:mainfrom Jun 13, 2024
Merged
Conversation
JimSuplizio
requested review from
benbp,
konrad-jamrozik,
mikeharder and
weshaggard
as code owners
|
PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
Contributor
Author
|
/azp run prepare-pipelines |
|
No pipelines are associated with this pull request. |
…ommon in rest-api-specs
weshaggard
approved these changes
Jun 13, 2024
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
I assume the linter.yml is an unchanged copy/paste from tools repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the other repositories that have the CODEOWNERS linter is enabled get the codeowners-linter.yml file pushed out as part of the eng/common sync. azure-rest-api-specs is not a repository that we sync eng/common with, meaning that if the version of the linter changes, this will need to be updated manually. Also of note, the working directory in the yml file is eng/common, which doesn't exist in this repo and had to be changed to eng/pipelines.
The pipeline is created, I ran a run against the refs/merge of this PR, and it passed, as expected.